[FFmpeg-devel] [PATCH] Remove unessesary assignment of CODEC_ID_BMP

mark cox markcox
Mon Jul 9 02:04:44 CEST 2007


On 08/07/07, M?ns Rullg?rd <mans at mansr.com> wrote:
>
> "mark cox" <melbournemark+ffmpeg at gmail.com> writes:
>
> > This patch removes the assignment of CODEC_ID_BMP because, it is already
> > assigned.
> > Regards,
> > mark
> >
> > Index: libavcodec/bmp.c
> > ===================================================================
> > --- libavcodec/bmp.c  (revision 9532)
> > +++ libavcodec/bmp.c  (working copy)
> > @@ -111,7 +111,7 @@
> >          rgb[2] = bytestream_get_le32(&buf);
> >      }
> >
> > -    avctx->codec_id = CODEC_ID_BMP;
> > +    assert(avctx->codec_id == CODEC_ID_BMP);
> >      avctx->width = width;
> >      avctx->height = height > 0? height: -height;
>
> Why the assert?  We don't do that for most of the codecs.


I thought no harm, and a bit of self-documentation.

--
> M?ns Rullg?rd
> mans at mansr.com
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>




More information about the ffmpeg-devel mailing list