[FFmpeg-devel] [patch] error codes for http/tcp
Wed Jul 11 11:58:29 CEST 2007
On Fri, Jul 06, 2007 at 08:18:42AM -0400, Ronald S. Bultje wrote:
> On 7/6/07, Diego Biurrun <diego at biurrun.de> wrote:
> > On Sat, Jun 23, 2007 at 11:27:21AM -0400, Ronald S. Bultje wrote:
> > > --- ffmpeg.orig/configure 2007-06-23 11:22:15.000000000 -0400
> > > +++ ffmpeg/configure 2007-06-23 11:23:19.000000000 -0400
> > > @@ -666,6 +666,7 @@
> > > fast_cmov
> > > fast_unaligned
> > > freetype2
> > > + gethostbyname_r
> > > imlib2
> > > inet_aton
> > > localtime_r
> > > @@ -1532,6 +1533,7 @@
> > >
> > > check_func inet_aton
> > > check_func localtime_r
> > > +check_func gethostbyname_r
> > > enabled zlib && check_lib zlib.h zlibVersion -lz || zlib="no"
> > This does not apply to HEAD any longer, otherwise it looks OK. Is the
> > whole of the patch still pending?
> Yes. Probably fails b/c localtime_r was removed, I can send a new patch if
> wanted, should be a piece of cake to hand-apply the configure part, though.
> The error-code patch needs to be re-send after this patch is applied, so
> don't bother looking at that one yet. (Thanks btw!)
Yes, it's trivial to make the adjustment, but AFAICT this patch did not
yet pass review by Michael. Am I mistaken?
I suggest that you update it to HEAD and go for another review round.
More information about the ffmpeg-devel