[FFmpeg-devel] [PATCH] move av_codec_get_tag to libavformat/utils.c

[Måns Rullgård]

Aurelien Jacobs wrote:
> Hi,
>
> Currently, compilation of libavformat fails when configured with the
> following parameters:
>
> ./configure --disable-muxers --disable-parsers --disable-demuxers
> --disable-encoders --disable-decoders --disable-bsfs
>
> Here is the error:
>
> libavformat/libavformat.a(utils.o): In function `av_write_header':
> libavformat/utils.c:2093: undefined reference to `av_codec_get_tag'
>
> av_codec_get_tag() is defined in riff.c which is compiled conditionally.
> This is wrong anyway. A function which is part of public API must
> be included un-conditionally.
>
> Solution 1: move av_codec_get_tag() into utils.c (see attached patch)
> Is it OK ?

If av_codec_get_tag() is moved, av_codec_get_id() should move too.  Also,
Michael has previously said that AVCodecTag should be publicly opaque.

> Solution 2: makes compilation of riff.c un-conditional (ugly but simple)

Please don't do that.

-- 
M?ns Rullg?rd
mans at mansr.com