[FFmpeg-devel] [PATCH] seeking in asf files where audio streamis found before video

elupus elupus
Sun Jul 15 00:38:12 CEST 2007


"Michael Niedermayer" <michaelni at gmx.at> wrote in message 
news:20070714195835.GN1669 at MichaelsNB...
> On Sun, Jul 08, 2007 at 12:00:10AM +0200, elupus wrote:
> >
> > This patch changes the demuxer to only load index for the video stream, 
> > and
> this is just wrong

> > fall back to the general seeks in utils.c if its internal seek doesn't 
> > work.
> good but why does this make a difference? it shouldnt, its a welcome 
> cleanup
> but i dont see how this would change anything

It doesn't, so this would be a separate patch then i suppose. Have no simple 
way to generate incremental patched, so i'll probably skip this part 
(atleast until other stuff get's applied)

> >      if (asf->packet_size <= 0)
> >          return -1;
> >
> > +    if (st->codec->codec_type != CODEC_TYPE_VIDEO)
> > +        return -1;
> > +
> why should we fail on all non video streams this is just a ugly
> hack

Technically it wouldn't fail completly as the general rutines would handle 
the seek instead. I suppose it's a matter of how one should interpret the 
asf index. ie if it's global or only refers to video frames.

If we consider the index in asf's global, how about always loading the index 
on the first asf stream (not neccesarily the one the seek was issued on) and 
always using that stream during seeks?


More information about the ffmpeg-devel mailing list