[FFmpeg-devel] Patch for folding unaligned access routines into one file

Michael Niedermayer michaelni
Sat Jul 28 02:04:48 CEST 2007


On Fri, Jul 27, 2007 at 01:40:16PM -0700, Roman Shaposhnick wrote:
> Guys,
> while cleaning up the __GNUC__ thing I've come across one peculiarity: 
> it seems that we've got two sets of pretty much identical routines
> for accessing unaligned data residing in 
>     libavutil/intreadwrite.h
> and libavcodec/bitstream.h. 
> The obvious question now is, should we fold them into one set by
> applying the attached patch?

yes but
maybe the folding of calls to stuff from intreadwrite.h / bitstream.h
should be folded in a seperate patch from the folding of the
implementations in *.h

also a quick benchmark (on x86) should be done to ensure that we
dont pick the slower of the 2 implementations

besides this ive nothing to add to mans review

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070728/2781ab9d/attachment.pgp>

More information about the ffmpeg-devel mailing list