[FFmpeg-devel] [PATCH] Add a codebook generator

Michael Niedermayer michaelni
Sat Jun 2 22:29:58 CEST 2007


Hi

On Sat, Jun 02, 2007 at 09:05:45PM +0200, Vitor wrote:
> Hi
> 
> Michael Niedermayer wrote:
> [...]
> >indention is 2 spaces here while its 4 spaces everywhere else
> >
> >
> >except these iam fine with the patch, ive been nitpicking enough on it ...
> >
> >[...]
> >  
> I suggest the log message "Codebook generator using the ELBG algorithm". 
> Is it worth a changelog entry?

of course, all cool sounding features should be mentioned in the changelog

and patch looks ok

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070602/f1d9f977/attachment.pgp>



More information about the ffmpeg-devel mailing list