[FFmpeg-devel] [PATCH] updated LGPL AC-3 decoder

Justin Ruggles justinruggles
Sun Jun 3 20:46:20 CEST 2007

Michael Niedermayer wrote:
> Hi
> On Mon, May 07, 2007 at 08:50:00PM -0400, Justin Ruggles wrote:
>>Michael Niedermayer wrote:
>>>and patch looks ok
>>great.  now...
>>Should I apply it all at once or try to go back to the original SoC code
>>and do incremental changes?  I looked back at the original, and my best
>>guess is that I changed about 75% of the code.  I could do it either way
> incremental is better if its easy, but if you use some script to
> automatically check all the revissions in then test it on a dummy
> repository first and ensure it can deal with errors
> the precommit check script might reject changes due to whitespace/tab issues
> or there might be a conflicting commit in the middle (extreemly unlikely i 
> know, but the script should stop if something unexpected happens ...)

I don't think I have the scriping skills to create such a thing.  I also
don't really have a repo to test with.  I noticed others are working on
last year's AAC decoder.  Are there plans to merge that into FFmpeg with
history?  If so, is there already a script out there to do this?

If others are willing to help with getting the AC-3 decoder from the SoC
branch to FFmpeg while preserving the history, I am willing to apply
incremental changes to the SoC code to bring it inline with the current
patch.  Otherwise, I think I should just apply it as-is so I don't screw
anything up.


More information about the ffmpeg-devel mailing list