[FFmpeg-devel] PATCH grab.c, adding support for hardware based VIDIOSFPS

mmh mmh
Mon Jun 4 17:04:10 CEST 2007


Benoit Fouet writes:
 > mmh wrote:
 > > Robert Swain writes:
 > >  > Hey,
 > >  > 
 > >  > On 4 Jun 2007, at 15:29, mmh wrote:
 > >  > > If the underlying video4linux driver supports frame rate control then
 > >  > > use it instead of user space software support.
 > >  > >
 > >  > > Index: grab.c
 > >  > > ===================================================================
 > >  > > --- grab.c	(revision 9203)
 > >  > > +++ grab.c	(working copy)
 > >  > 
 > >  > [...]
 > >  > 
 > >  > I don't think people like inline diffs here. Diff files as  
 > >  > attachments are much preferred, for your information. :)
 > >  > 
 > >
 > > Hi Robert,
 > >
 > > I use (vm-mime-attach-file "~/ffmpeg-svn/libavformat/grab.fps.p3")
 > > inside of emacs.  I guess I need to compile and try to use mutt as
 > > Diego suggested I will try to migrate to that this week.
 > >
 > > I have been using svn diff to create the patches is this the correct
 > > procedure?  I do know that this should have been created from the
 > > toplevel sorry.
 > 
 > given the fact that you're likely to be the one who will apply it, i
 > guess it is not a problem :)
 > 
 > >   However, I figured the most important thing is to have
 > > Michael review the semantics before I commit this small change.
 > >
 > >   
 > 
 > i personnaly don't think it is so "small"
 > 

no change is small in a large system is it.

:)





More information about the ffmpeg-devel mailing list