[FFmpeg-devel] [RFC] move wmv2.c to its own file
Mon Jun 4 21:23:39 CEST 2007
Aurelien Jacobs a ?crit :
> On Fri, 18 May 2007 11:46:40 +0200
> Diego Biurrun <diego at biurrun.de> wrote:
>> On Fri, May 11, 2007 at 11:35:29PM +0200, Diego Biurrun wrote:
>>> This is a rough draft for moving wmv2.c to its own file, i.e. make it
>>> not be just an include from msmpeg4.c.
>> Here is the second try. Unfortunately the patch is starting to become
>> large and the resulting libavcodec.a is about 100k bigger than the
>> original. I'm sure you guys can tell me how to avoid this...
> You include msmpeg4tab.h in msmpeg4.h which is then included both
> in msmpeg4.c and wmv2.c. This duplicates the static tables in the
> 2 objects.
> msmpeg4tab.h *must* only be included from a single .c file.
> Tables which needs to be shared between the 2 .c files *must*
> be moved to msmpeg4data.c.
> This should solve the libavcodec.a size increase.
> About the size of your patch, you may want to split function renaming
> (adding ff_ prefix) from the rest of the patch.
What happened to this patch ?
I will need some msmpeg4 functions inside vc1 encoder so this patch is
something i need to avoid including a .c file inside msmpeg4.c.
Attached is a patch which moves code_012 to ff_code012 (and nothing
else). It's just a reminder for Diego's patch and i don't expect to see
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 2438 bytes
Desc: not available
More information about the ffmpeg-devel