[FFmpeg-devel] [RFC] move wmv2.c to its own file

Denis Fortin fortin
Wed Jun 6 21:37:18 CEST 2007

Denis Fortin a ?crit :
> Aurelien Jacobs a ?crit :
>> On Fri, 18 May 2007 11:46:40 +0200
>> Diego Biurrun <diego at biurrun.de> wrote:
>>> On Fri, May 11, 2007 at 11:35:29PM +0200, Diego Biurrun wrote:
>>>> This is a rough draft for moving wmv2.c to its own file, i.e. make it
>>>> not be just an include from msmpeg4.c[1].
>>> Here is the second try.  Unfortunately the patch is starting to become
>>> large and the resulting libavcodec.a is about 100k bigger than the
>>> original.  I'm sure you guys can tell me how to avoid this...
>> You include msmpeg4tab.h in msmpeg4.h which is then included both
>> in msmpeg4.c and wmv2.c. This duplicates the static tables in the
>> 2 objects.
>> msmpeg4tab.h *must* only be included from a single .c file.
>> Tables which needs to be shared between the 2 .c files *must*
>> be moved to msmpeg4data.c.
>> This should solve the libavcodec.a size increase.
>> About the size of your patch, you may want to split function renaming
>> (adding ff_ prefix) from the rest of the patch.
> What happened to this patch ?
> I will need some msmpeg4 functions inside vc1 encoder so this patch is 
> something i need to avoid including a .c file  inside msmpeg4.c.
> Attached is a patch which moves code_012 to ff_code012 (and nothing 
> else). It's just a reminder for Diego's patch and i don't expect to see 
> mine applied.
> Denis

Here's another patch to export two other functions i used in vc1 encoder 
(no more needed for the moment).

-------------- next part --------------
A non-text attachment was scrubbed...
Name: find_best_tables.patch
Type: text/x-patch
Size: 2496 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070606/6107a5a9/attachment.bin>

More information about the ffmpeg-devel mailing list