[FFmpeg-devel] [RFC] move wmv2.c to its own file
Thu Jun 7 22:35:43 CEST 2007
On Thu, Jun 07, 2007 at 09:33:23PM +0200, Denis Fortin wrote:
> >>> Attached is a patch which moves code_012 to ff_code012 (and nothing
> >>> else). It's just a reminder for Diego's patch and i don't expect to see
> >>> mine applied.
> >>> Denis
> >> Here's another patch to export two other functions i used in vc1 encoder
> >> (no more needed for the moment).
> >> Denis
> >> Index: libavcodec/msmpeg4.c
> >> ===================================================================
> >> --- libavcodec/msmpeg4.c (r??vision 9235)
> >> +++ libavcodec/msmpeg4.c (copie de travail)
> >> @@ -61,7 +61,7 @@
> >> static uint32_t v2_dc_lum_table;
> >> static uint32_t v2_dc_chroma_table;
> >> -static inline void msmpeg4_encode_block(MpegEncContext * s, DCTELEM * block, int n);
> >> +inline void ff_msmpeg4_encode_block(MpegEncContext * s, DCTELEM * block, int n);
> > its extern inline IIRC and gcc does not support it IIRC
> I'm not sure to understand what you meant:
> should i remove the inline ?
If all of the
file scope declarations for a function in a translation unit include the inline function
specifer without extern, then the definition in that translation unit is an inline
definition. An inline definition does not provide an external definition for the function,
-> you cannot use a inline void ff_msmpeg4_encode_block() from another
it works with gcc only because gcc does not implement inline correctly
in gcc "inline" is some sort of randomly ignoreable keyword
also simply removing inline would require some benchmarks ...
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the ffmpeg-devel