[FFmpeg-devel] [PATCH] imlib2's rgb.txt
Ramiro Ribeiro Polla
Mon Jun 11 18:11:36 CEST 2007
Michael Niedermayer wrote:
> On Mon, Jun 11, 2007 at 09:06:34AM +0200, V?ctor Paesa wrote:
>>> Attached patch adds another location for the imlib2 vhook to search for
>>> It's a relative path instead of an absolute path, good for Windows,
>>> where X11 isn't installed.
>>> Even though vhooks should go away soon, it's nice for the next filter
>>> system to support this too, so this patch is also informative for
>>> whoever writes the next imlib2 filter.
>> The patch is also useful for POSIX systems that don't have X11 installed, or
>> have it installed in unusual directories.
> would it not make more sense to allow the user to specifiy the file path?
Yes, it would.
Also, it would make sense to add hex value support like drawtext.
How about this:
- add -rgb parameter to specify rgb.txt file
- remove the 2 default paths for rgb.txt (ok?)
- copy ParseColor (from drawtext.c), or put function in some shared
file. (does lav* have a function for parsing hex colors?)
- if parse color fails, read from rgb.txt (or the other way around?)
More information about the ffmpeg-devel