[FFmpeg-devel] [PATCH] Compile libswscale without MMX, MMX2 and 3DNOW code

Michael Niedermayer michaelni
Wed Jun 13 02:22:44 CEST 2007


Hi

On Tue, Jun 12, 2007 at 10:33:03PM +0000, Carl Eugen Hoyos wrote:
> Hi!
> 
> [...]
> 
> > > > the problem is code like
> > > >
> > > > #define HAVE_MMX
> > > > #undef HAVE_MMX2
> > > > ...
> > > > #include "foobar_template.h"
> > > >
> > > > #define HAVE_MMX
> > > > #define HAVE_MMX2
> > > > ...
> > > > #include "foobar_template.h"
> > > >
> > > > this cant be just put under #ifdef HAVE_MMX2 ...
> > > 
> > > Such code is conflicting with the intention of the HAVE_* macros.
> > > Temporary macros used with multiple inclusion of templates like this
> > > should use some other name.
> > 
> > Perhaps as in the attached patch?
> 
> Could someone comment on the patch?
> 
> I don't need it (it also makes not much sense for icc), but users can't disable
> optimzed compilation in libswscale as it's possible in libpostproc.

iam against this patch, i would prefer if someone would cleanup swscale so
c and asm isnt interleaved everywhere ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070613/0f353d20/attachment.pgp>



More information about the ffmpeg-devel mailing list