[FFmpeg-devel] remove int readers
Thu Jun 14 10:11:10 CEST 2007
Reimar Doeffinger wrote:
> On Thu, Jun 14, 2007 at 08:21:08AM +0100, M?ns Rullg?rd wrote:
>> "Ronald S. Bultje" <rsbultje at gmail.com> writes:
>> > On 6/14/07, mark cox <melbournemark+ffmpeg at gmail.com> wrote:
>> >> - seq = (buf << 8) | buf;
>> >> + seq = AV_RB16(buf + 2);
>> >> Why have you changed all the indexes from  to +.  are preferred
>> >> because they avoid compiler warnings and are easier to read IMHO.
>> > Consistency with the rest of the code. I prefer &buf also, but I try to
>> > conform to what's already there.
>> &buf is IMO far harder to read than buf + 2, and it's ugly to
> I don't think we will ever get a common opinion on this, I usually prefer
> &buf syntax and find buf + 2 ugly ;-)
Did you by any chance study computer science in university with some fool
of a professor brainwashing you with the &buf construct being "safer"
crap until you finally cracked and started believing it?
mans at mansr.com
More information about the ffmpeg-devel