[FFmpeg-devel] remove int readers
Thu Jun 14 10:18:32 CEST 2007
On Thu, Jun 14, 2007 at 09:59:32AM +0200, Reimar Doeffinger wrote:
> On Thu, Jun 14, 2007 at 08:21:08AM +0100, M?ns Rullg?rd wrote:
> > "Ronald S. Bultje" <rsbultje at gmail.com> writes:
> > > On 6/14/07, mark cox <melbournemark+ffmpeg at gmail.com> wrote:
> > >>
> > >> - seq = (buf << 8) | buf;
> > >> + seq = AV_RB16(buf + 2);
> > >>
> > >> Why have you changed all the indexes from  to +.  are preferred
> > >> because they avoid compiler warnings and are easier to read IMHO.
> > >
> > > Consistency with the rest of the code. I prefer &buf also, but I try to
> > > conform to what's already there.
> > &buf is IMO far harder to read than buf + 2, and it's ugly to
> > boot.
> I don't think we will ever get a common opinion on this, I usually prefer
> &buf syntax and find buf + 2 ugly ;-)
i am on mans side this time :)
also +2 is 2 chars & is 4 so its simpler ;)
anyway, we should be carefull to seperating such bikeshed issues from real
clear readability issues, i dont want ffmpeg to become known for rejecting
patches because of such style issues ...
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the ffmpeg-devel