[FFmpeg-devel] [PATCH] h264 parallelized, (was: Parallelized h264 proof-of-concept)

Guillaume POIRIER poirierg
Sat Jun 16 21:57:47 CEST 2007


Hi,

On 6/16/07, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Fri, Jun 15, 2007 at 10:10:54PM +0200, Andreas ?man wrote:
> > Okay, here are the finalized patches.
> >
> > #1 - Extend MPV_common_init() with an addition arg for context size
> >      when doing multi threading.
>
> hmm, seeing the patch, i think i would prefer some simpler solution,
> maybe adding the size to MpegEncContext? or even better adding
> thread_context[] to H264Context, this would also avoid the casts to
> H264Context
>
>
> >
> > #2 - Factor out init_scan_tables()
>
> looks ok (and can be applied)

Works on my samples, Applied.


> > #3 - Decouple bit context from h264 context in decode_ref_pic_marking()
>
> looks ok (and can be applied)

Doesn't compile:

cc -I../libswscale -I../libavcodec  -DHAVE_AV_CONFIG_H
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_ISOC9X_SOURCE -I.. -I..
-I../libavutil -Wdisabled-optimization -Wno-pointer-sign
-Wdeclaration-after-statement -I. -I.. -I../libavutil -Wall
-Wno-switch -Wpointer-arith -Wredundant-decls -O4 -march=pentium-m
-mtune=pentium-m -pipe -ffast-math -fomit-frame-pointer
-mdynamic-no-pic -falign-loops=16 -DSYS_DARWIN -DCONFIG_DARWIN
-shared-libgcc -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
-D_LARGEFILE64_SOURCE -I/Users/guillaume/Prgm/x264
-I/usr/local/include -I/opt/local/include/freetype2
-I/opt/local/include  -c -o h264.o h264.c
In file included from dsputil.h:33,
                 from h264.c:29:
avcodec.h:2252: warning: 'ImgReSampleContext' is deprecated
avcodec.h:2258: warning: 'ImgReSampleContext' is deprecated
h264.c: In function 'hl_decode_mb_internal':
h264.c:3193: warning: suggest parentheses around arithmetic in operand of ^
h264.c:3199: warning: suggest parentheses around arithmetic in operand of ^
h264.c: In function 'decode_slice_header':
h264.c:4419: error: 'h0' undeclared (first use in this function)
h264.c:4419: error: (Each undeclared identifier is reported only once
h264.c:4419: error: for each function it appears in.)
h264.c: In function 'decode_cabac_residual':
h264.c:5774: warning: passing argument 4 of
'decode_significance_8x8_x86' discards qualifiers from pointer target
type
h264.c:5701: warning: unused variable 'last'
make[1]: *** [h264.o] Error 1
make: *** [libavcodec/libavcodec.a] Error 2


Guillaume
-- 
Subversion has been the most pointless project ever started
  -- Linus Torvalds



More information about the ffmpeg-devel mailing list