[FFmpeg-devel] MPEG-2 Acceleration Refactor

Corey Hickey bugfood-ml
Mon Jun 18 07:20:41 CEST 2007

Greg Hulands wrote:
> I'll definitely submit a revlon patch once it is committed just to clean 
> it up a bit.

:)  I had to think for a moment there. I guess I don't pay attention to
enough advertising.

> @@ -1638,7 +1642,10 @@
>          /* special case for the first coef. no need to add a second vlc table */
>          UPDATE_CACHE(re, &s->gb);
>          if (((int32_t)GET_CACHE(re, &s->gb)) < 0) {
> -            level= (3*qscale*quant_matrix[0])>>5;
> +            if (speed == DECODE_FAST)
> +               level= (3*qscale)>>1;
> +            else
> +               level= (3*qscale*quant_matrix[0])>>5;

I missed them last time, but I think the quoted line immediately above
should remain at the same indentation so it doesn't look changed. There
are some other instances like this further down.

Other than that, I don't see anything cosmetically wrong, so if anybody
submits the patch to closer scrutiny, hopefully few problems will remain.


More information about the ffmpeg-devel mailing list