[FFmpeg-devel] dv_read_seek over 2GB fix

Maksym Veremeyenko verem
Mon Jun 18 21:25:36 CEST 2007


Roman Shaposhnick ?????:

> On Mon, 2007-06-18 at 19:03 +0300, Maksym Veremeyenko wrote:
>> Michael Niedermayer ?????:
>>
>>> offset_t url_fseek(ByteIOContext *s, offset_t offset, int whence)
>>> {
>>> [...]
>>>         return AVERROR(EINVAL);
>>> [...]
>>>         offset_t res = AVERROR(EPIPE);
>>>
>>>
>>>> this value re-returned to av_seek_frame that 
>>>> do not care about error code - it's interesting only in sign of returned 
>>>> value from:
>>> its not relevant if any current code checks for specific errors or just
>>> error vs. no error, the code should properly pass error codes
>> this version of attached patch returns 0 on success or negative error code.
> 
>   At this point I sort of lost track of this patch. Is the one attached
> a complete one?
I think so, it's only fix 64-bit offset convertion to 32-bit value issue 
i described early.

Separate audio stream seek fix will be re-posted later.

-- 
________________________________________
Maksym Veremeyenko




More information about the ffmpeg-devel mailing list