[FFmpeg-devel] dv_read_seek over 2GB fix
Wed Jun 20 13:18:45 CEST 2007
On Tue, Jun 19, 2007 at 07:01:51PM -0700, Roman Shaposhnick wrote:
> > > > problem is in "truncating" returned value...
> > > >
> > > > Is this patch OK? Could you commit this one?
> > >
> > > I still have the same question (I guess Michael should be the one
> > > to really answer it): what is the semantics of the
> > > AVInputFormat::read_seek() return value (and perhaps we should even
> > > include the description of the semantics into the avformat.h).
> > <0 is error, ideally a proper error code
> > >=0 is no error
> > the meaning of the individual >=0 is unspecified currently, that might
> > change though
> > what does matter is that if no error happens then the return should be
> > >= 0
> In that case the patch seems to be ok. I would *really* love to see
> you, Michael, commit the one or two lines about the current semantics
> of AVInputFormat::read_seek to the avformat.h.
i too want to but iam too lazy, why dont you commit it :)
> Unless, of course, I'm
> the only one who expects the function named *seek to return new
> offset on success.
i too would expect the offset but it simply doesnt fit in the int and
changing it to int64_t is not so easily possible
if you want, this change could be done under the appropriate
#ifdef BLAH_VERSION > 1234
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the ffmpeg-devel