[FFmpeg-devel] remove int readers

Aurelien Jacobs aurel
Sat Jun 23 14:46:14 CEST 2007


On Fri, 22 Jun 2007 22:08:58 -0400
"Ronald S. Bultje" <rsbultje at gmail.com> wrote:

> Hi,
> 
> On 6/22/07, Ramiro Ribeiro Polla <ramiro at lisha.ufsc.br> wrote:
> >
> > It no longer applies. Could you send an updated patch?
> > And please svn diff it from the source folder.
> 
> 
> I think it's common to use a source-folder patch (i.e. one that is applied
> with -p1 from the source folder)? At least that is kernel-style... Anyone
> else wants me to switch to -p0 (does anyone really care?)?

As long as it can be applied with -p0 or -p1, I don't care
(I even have a slight preference for -p1)

> New patch with get_bits_long for oggparsetheora, removed the (offset) cast
> in ffm.c attached. I left the get_pts() in the mpeg reader as-is, if
> everyone hates it I'll change it...

I just applied the vocdec and matroskadec part of this patch
(slightly modified).

Other parts of the patch seems OK too.
(get_pts() looks slightly ugly, but I don't care much)

Aurel




More information about the ffmpeg-devel mailing list