[FFmpeg-devel] [PATCH] Codec lookup: do not use codec_id

[Nicolas George]

Le duodi 2 messidor, an CCXV, Michael Niedermayer a ?crit?:
> i have a very bad feeling about this, this needs very extensive testing

I agree about the need of extensive testing, although I am pretty sure that
the particular point we were discussing is ok: if there is a problem, it is
more likely spread on the whole change of logic.

> stream copy with missing decoder/encoder and multiple input and output files
> amongth others

I have tested the following:

(a and b are two video files with different codecs)

./ffmpeg -i $a /tmp/t.avi -newvideo -i $b

-> produces one file with two video streams, mplayer can play both

./ffmpeg -i $a /tmp/t.avi -newaudio -i $b

-> produces one file with two audio streams, mplayer can play both and
switch with #.

./ffmpeg -i $a -acodec mp2 -vcodec mpeg4 /tmp/t.avi \
  -acodec ac3 -vcodec mpeg2video /tmp/t2.avi

-> produces two files with one audio and one video stream each, and with the
requested codec, mplayer can play both and reports the correct codec

./ffmpeg -i $b -acodec copy -vcodec copy /tmp/t.avi

-> produces one file very similar to $b

./ffmpeg -i $a -acodec copy -vcodec copy /tmp/t.avi

-> fails with "Could not write header for output file #0 (incorrect codec
parameters ?)", but replacing t.avi by t.mov works ($a is a QuickTime
video), so no problem here.

Are there other tests you think necessary?

> i see, could you still please remove it for changes to files which use
> a different style

Ok. I will adapt when re-submitting the patch.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 185 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070625/b3bec871/attachment.pgp>