[FFmpeg-devel] [PATCH] RoQ video encoder (take 4)

[Vitor]

Hi

Benoit Fouet wrote:
> Vitor wrote:
>> +static void gather_data_for_cel(cel_evaluation_t *cel, RoqContext *enc,
>> +                                roq_tempdata_t *tempData)
>> +{
>>
>> [snip]
>>
>> +    if (cel->best_coding == RoQ_ID_CCC)
>> +        for (i=0; i<4; i++)
>> +            if (cel->subCels[i].best_coding == RoQ_ID_SLD)
>> +                tempData->codebooks.usedCB4[cel->subCels[i].cbEntry]++;
>> +            else if (cel->subCels[i].best_coding == RoQ_ID_CCC)
>> +                for (j=0; j<4; j++)
>> +                    tempData->codebooks.usedCB2[cel->subCels[i].subCels[j]]++;
>> +}
>> +
> 
> would it be possible to add braces here, or am i the only to wish it ?

I have nothing against it, the else clause is a little bit ambiguous as is.

-Vitor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: roq_video7.diff
Type: text/x-patch
Size: 36323 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070625/ae430c8b/attachment.bin>