[FFmpeg-devel] [PATCH] play aiff without common tag

[Baptiste Coudurier]

Hi

Michael Niedermayer wrote:
> Hi
> 
> On Mon, Jun 25, 2007 at 07:21:20PM +0200, Michael Niedermayer wrote:
>> Hi
>>
>> On Mon, Jun 25, 2007 at 05:51:59PM +0200, Reimar D?ffinger wrote:
>>> Hello,
>>> attached patch fixes
>>> http://samples.mplayerhq.hu/AIFF/invalid_nocommon.aiff.
>>> While according to the specification says this file invalid I think it
>>> is preferable to support it anyway, esp. because leaving values
>>> uninitialized and even causing a division by zero is really bad anyway
>>> (and it even leaves e.g. MPlayer thinking this is a video file...).
>> looks ok
> 
> hmm ive just noticed baptiste is maintainer of aiff ...
> so its his decission
> 
> but id like to repeat that ffmpeg CANNOT reject files just because they
> are not conforming to specs, we would be rejecting >50% of all files
> otherwise and ffmpeg would be unuseable
> 

I agree with that.

Now having such workaround like setting default codec, bits per sample,
and sample rate is a too heavy workaround IMHO.

It would be like assuming codec is divx, size is 640x480 when 'vids' tag
is missing in some avi file.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312