[FFmpeg-devel] A question about AVOutputFormat.write_trailer (cosmetical)
Wed Jun 27 01:20:05 CEST 2007
Aurelien Jacobs wrote:
> On Tue, 26 Jun 2007 22:48:21 +0200
> Vitor <vitor1001 at gmail.com> wrote:
>> Michael Niedermayer wrote:
>>> On Tue, Jun 26, 2007 at 09:07:50PM +0200, Vitor wrote:
>>>> For a good number of muxers (notably in raw.c), there is an empty
>>>> function that is passed to AVOutputFormat.write_trailer. The only place
>>>> it is called checks for a NULL pointer, and almost every muxer pass a
>>>> NULL pointer to AVOutputFormat.interleave_packet. So would it be ok to
>>>> send a patch to remove all those empty functions and set write_trailer
>>>> to NULL instead?
>> Patch attached.
>> @@ -119,5 +114,5 @@
>> - adts_write_trailer,
>> + NULL,
> The NULL here is absolutely useless. IMHO, you should simply remove the
> write_trailer line (here and everywhere else in your patch).
You're right. Patch attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 4788 bytes
Desc: not available
More information about the ffmpeg-devel