[FFmpeg-devel] [PATCH] split mpegvideo.c
Thu Jun 28 08:51:21 CEST 2007
M?ns Rullg?rd wrote:
> Benoit Fouet <benoit.fouet at purplelabs.com> writes:
>> here is a first attempt to $subj
>> what is done:
>> - remove everything flagged under CONFIG_ENCODERS from mpegvideo.c
>> (apart from the DCT_common_init() part)
>> - put those parts in mpegvideo_enc.c
> Does this in any way affect performance? I can imagine calls from
> encoding functions to common functions no longer being inlined due to
> the split. Then again, there might not be any relevant such calls.
i didn't check performances yet. but this is a problem we might have, i
>> - put in mpegvideo_common.heverything that's needed by both encoder and
> The usual naming convention would see common stuff in mpegvideo.h,
> while encoder/decoder specific bits would go in mpegvideoenc.h and
the problem here is that mpegvideo.h already exists for functions used
externally to mpegvideo
maybe a mpegvideointernal.h, or something like that could do it ?
Purple Labs S.A.
More information about the ffmpeg-devel