[FFmpeg-devel] [PATCH] Fix connect return EWOULDBLOCK not EINPROGRESS under mingw

[Víctor Paesa]

Hi,

Michael Niedermayer said:
> Hi
>
> On Fri, Jun 29, 2007 at 07:16:25AM +0200, V?ctor Paesa wrote:
>> Hi,
>>
>> Michael Niedermayer dijo:
>> > Hi
>> >
>> > On Fri, Jun 29, 2007 at 01:21:34AM +0200, Alex Beregszaszi wrote:
>> >> Hi,
>> >>
>> >> > > A connect in windows doesn't return EINPROGRESS as is customary
>> >> for a non blocking socket, it returns EWOULDBLOCK. By redefining
>> WSAEWOULDBLOCK to WSAEINPROGRESS tcp.c works just fine.
>> >> > >
>> >> > > EINPROGRESS in windows has some very odd meaning, and wouldn't
>> >> make sense to check for anyway, so think this patch is fine.
>> >> >
>> >> > do we have a win32 maintainer?
>> >> > if there are any volunteers, id be very happy to loose the
>> implicit
>> >> ffmpeg-win32 maintainer role
>> >>
>> >> We have an other fix for this in the tree.
>> >>
>> >> And how many times do we need to discuss this win32 maintainership?
>> >
>> > there are exactly 3 threads (including your
>> > "We have an other fix for this in the tree" from above) with mingw
>> and [PATCH] in the subject to which you replied ever
>> > there are none with cygwin in the subject
>> > search for mingw and [PATCH] there are many pages
>> >
>> > that is NOT maintaining windows support nor mingw support
>> >
>> > and even if you would maintain it you just maintain mingw, we either
>> way still need a maintainer for cygwin
>>
>> I volunteer to maintain Cygwin.
>
> great, add yourself to the respective place in MAINTAINERS please

Done. I must say that Cygwin POSIX emulation is quite good, and hence
(except maybe for changes in the building area) I expect this
maintainership to be a light task :-)

Regards,
V?ctor