[Ffmpeg-devel] [PATCH] ffmpeg.c duplicate *_opts for every codec types

Michael Niedermayer michaelni
Thu Mar 1 15:05:04 CET 2007


Hi

On Thu, Mar 01, 2007 at 08:35:11AM +0100, Benoit Fouet wrote:
> Hi,
> 
> Benoit Fouet wrote:
> > Hi,
> >
> > Michael Niedermayer wrote:
> >   
> >> Hi
> >>
> >> On Mon, Feb 26, 2007 at 12:54:12PM +0100, Benoit Fouet wrote:
> >>   
> >>     
> >>> Hi,
> >>>
> >>> Benoit Fouet wrote:
> >>>     
> >>>       
> >>>> i'll come back soon with another patch...
> >>>>   
> >>>>       
> >>>>         
> >>> here it is...
> >>> Note that for the moment, only audio, video and subtitle are handled in
> >>> opt_default. I guess the other ones could be added on need. Thoughts ?
> >>>     
> >>>       
> >> if there are no objections from anyone else, it works and the regression
> >> tests pass then iam fine with it
> >>
> >> [...]
> >>   
> >>   
> >>     
> > AFAIK, for the moment, it does nothing as options are handled before
> > getting to the opt_default function...
> > regression tests passed (r8131 + this patch)
> > i've tried it to convert with various options, end it worked for me...
> > if some of you can try to apply this patch and see if it works correctly
> > with you, i'd be grateful :)
> >
> > Ben
> >
> >   
> did anyone have the time to test it too ?
> are there any thoughts / remarks on that ?

as noone replied -> noone had objections
you said regression tests pass 
-> looks ok and can be applied

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070301/a1551f3e/attachment.pgp>



More information about the ffmpeg-devel mailing list