[Ffmpeg-devel] Stack overflow patch

Kristian Amlie kristian
Fri Mar 2 03:53:58 CET 2007


Quoting Michael Niedermayer <michaelni at gmx.at>:

> On Thu, Mar 01, 2007 at 02:29:48PM -0800, Kristian Amlie wrote:
>
>> This patch fixes ffmpeg so that av_find_stream_info() can be called
>> from MSVC++ without causing a stack overflow. It does so by replacing
>> the auto array "duration_error" with a malloced array.
>>
> rejected, learn C what you write is a array of pointers, what it should be
> is a pointer to array, difference is that its about 5 times less code

Right you are. My frequent C++/STL use has obviously dulled my senses.

This patch should be better.

Regards
Kristian Amlie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-stack-overflow-r2.patch
Type: text/x-patch
Size: 1358 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070301/fab137e3/attachment.bin>



More information about the ffmpeg-devel mailing list