[Ffmpeg-devel] Stack overflow patch

Guillaume POIRIER poirierg
Fri Mar 2 14:23:40 CET 2007


Hi,

On 3/2/07, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Thu, Mar 01, 2007 at 06:53:58PM -0800, Kristian Amlie wrote:
> > Quoting Michael Niedermayer <michaelni at gmx.at>:
> >
> > >On Thu, Mar 01, 2007 at 02:29:48PM -0800, Kristian Amlie wrote:
> > >
> > >>This patch fixes ffmpeg so that av_find_stream_info() can be called
> > >>from MSVC++ without causing a stack overflow. It does so by replacing
> > >>the auto array "duration_error" with a malloced array.
> > >>
> > >rejected, learn C what you write is a array of pointers, what it should be
> > >is a pointer to array, difference is that its about 5 times less code
> >
> > Right you are. My frequent C++/STL use has obviously dulled my senses.
> >
> > This patch should be better.
>
> yes looks ok

Applied.

Guillaume




More information about the ffmpeg-devel mailing list