[Ffmpeg-devel] [PATCH] Move libavformat Doxygen and other comments to avformat.h

Panagiotis Issaris takis
Sat Mar 3 21:34:21 CET 2007


Panagiotis Issaris schreef:
> Hi,
>
> Michael Niedermayer schreef:
>> On Thu, Mar 01, 2007 at 05:12:46PM +0100, Panagiotis Issaris wrote:
>>  
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>> Hi,
>>>
>>> The attached patch moves the libavformat public API comments to
>>> avformat.h. The comments are unmodified.
>>>
>>>     
>> [...]
>>  
>>> +/**
>>> + * Print  nice hexa dump of a buffer
>>> + * @param f stream for output
>>> + * @param buf buffer
>>> + * @param size buffer size
>>> + */
>>>  void av_hex_dump(FILE *f, uint8_t *buf, int size);
>>> +
>>> +/**
>>> + * Print on 'f' a nice dump of a packet
>>> + * @param f stream for output
>>> + * @param pkt packet to dump
>>> + * @param dump_payload true if the payload must be displayed too
>>> + */
>>>  void av_pkt_dump(FILE *f, AVPacket *pkt, int dump_payload);
>>>     
>>
>> these should be changed to av_logish style, (FILE dependancy sucks ...)
>> thats of course seperate and independant of this patch
>>   
> OK, I'll write a patch for this later today.
Oh, and furthermore, should I give the new av_(pkt|hex)_dump new names? 
Or how should the API change be handled?


av_hex_dump_log & av_pkt_dump_log
av_hex_log      & av_pkt_log
av_hex_dump2    & av_pkt_dump2


With friendly regards,
Takis




More information about the ffmpeg-devel mailing list