[Ffmpeg-devel] [PATCH] accept only existing bitrates in amr.c

Michael Niedermayer michaelni
Wed Mar 7 18:34:51 CET 2007


Hi

On Tue, Mar 06, 2007 at 09:53:32AM +0100, Benoit Fouet wrote:
> Hi,
> 
> Benoit Fouet wrote:
> > Hi,
> >
> > M?ns Rullg?rd wrote:
> >   
> >> Michael Niedermayer <michaelni at gmx.at> writes:
> >>
> >>   
> >>     
> >>> i prefer using the return value for both enum and -1 error yes, enum==int
> >>> anyway
> >>> or if you recently have been brainwashed by some CS teachers then just add
> >>> a enum entry for error and give it the value -1
> >>>     
> >>>       
> >> An enum isn't required to be int.  The compiler may choose any integer
> >> type capable of representing the full range of the enum values.  The
> >> enumeration constants have type int, but that's another matter.
> >>
> >>   
> >>     
> >
> > well, the enumerated has a unsigned type in our case...
> > so, i can either have two different behaviours for NB and WB, or change
> > "enum Mode mode" to "int mode" in AMR context...
> > i don't know what is better to do...
> for you to see the difference, new patch attached...

patch ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070307/f6010d71/attachment.pgp>



More information about the ffmpeg-devel mailing list