[Ffmpeg-devel] [PATCH] remove ac3 tables from parser.c

Michael Niedermayer michaelni
Fri Mar 9 00:39:29 CET 2007


Hi

On Thu, Mar 08, 2007 at 06:21:09PM -0500, Justin Ruggles wrote:
> This removes duplication in the AC-3 tables between encoder and parser.
> 
> For now, there is not a place for common AC-3 code, so with this patch,
> parser.c includes ac3tab.h.  Once there is an ac3.c, parser.c will be
> changed to include ac3.h instead.

this effectively duplicates the table in the object files as every file
which includes ac3tab.h would have a duplicated table ...

[...]

>  static const uint8_t eac3_blocks[4] = {
>      1, 2, 3, 6
>  };
> @@ -672,7 +621,7 @@
>          fscod = get_bits(&bits, 2);
>          frmsizecod = get_bits(&bits, 6);
>  
> -        if(fscod == 3)
> +        if(fscod == 3 || frmsizecod > 37)
>              return 0;

unrelated change?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070309/5b651773/attachment.pgp>



More information about the ffmpeg-devel mailing list