[Ffmpeg-devel] [PATCH] remove ac3 tables from parser.c

Michael Niedermayer michaelni
Fri Mar 9 03:46:38 CET 2007


On Fri, Mar 09, 2007 at 09:55:47AM +0800, Limin Wang wrote:
> Hi,
> * Justin Ruggles <justinruggles at bellsouth.net> [2007-03-08 18:21:09 -0500]:
> > This removes duplication in the AC-3 tables between encoder and parser.
> > 
> > For now, there is not a place for common AC-3 code, so with this patch,
> > parser.c includes ac3tab.h.  Once there is an ac3.c, parser.c will be
> > changed to include ac3.h instead.
> > 
> > -Justin
> I think table data shouldn't put into header file. we can put it into c file
> and extern the array in the header file or define a function to get it.
> So just remove the static and extern them in ac3tab.h.

yes but here the goal is to reduce the difference between svn and justins
ac3 decoder which #includes ac3tab.h only from 1 file
moving the tables somewhere else would not reduce the ac3 decoder patch
size, so the temporary duplication of the tables is the smaller evil IMHO
the alternative would involve alot of extra work with no advanatge for the
final ac3 decoder or the svn history 

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070309/2b26b684/attachment.pgp>

More information about the ffmpeg-devel mailing list