[Ffmpeg-devel] [PATCH] separate AC-3 common code

Justin Ruggles justinruggles
Fri Mar 9 05:22:00 CET 2007


Hello,

I split this change into 2 patches.  I don't know if it's better to
apply both at the same time or to do it in 2 commits.

The first patch creates, but does not build or use, a new file ac3.c as
svn copy of ac3enc.c.  It is trimmed to only have the core bit
allocation and common initialization functions.

The second patch removes the common code from ac3enc.c, changes the
shared tables to non-static with ff_ prefix, and enables compilation of
ac3.c.

One thing I'm not sure about is the best location for the fixed-point
ac3_window table.  It will not be used by the decoder or the parser, so
does it really belong in ac3tab.h?  Maybe it should be moved to
ac3enc.c.  What do you think?

-Justin
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: create_ac3_c.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070308/47291d7a/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: utilize_ac3_c.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070308/47291d7a/attachment.asc>



More information about the ffmpeg-devel mailing list