[Ffmpeg-devel] [PATCH] Fix compilation when using --disable-opts

Måns Rullgård mans
Thu Mar 15 20:15:09 CET 2007


Aurelien Jacobs <aurel at gnuage.org> writes:

> On Thu, 15 Mar 2007 18:26:47 +0100
> Panagiotis Issaris <takis.issaris at uhasselt.be> wrote:
>
>> Hi,
>> 
>> M?ns Rullg?rd schreef:
>> > Diego Biurrun said:
>> >> On Thu, Mar 15, 2007 at 05:58:35PM +0100, Panagiotis Issaris wrote:
>> >>> The attached patch fixes compilation when using the --disable-opts
>> >>> parameter. This to help those interested in using a debugger to debug
>> >>> FFmpeg.
>> >> Looks good.
>> > 
>> > No, the configure changes lack indentation.
>> Like this?
>> 
>> [...]
>> 
>> @@ -1390,6 +1392,31 @@ if test "$?" != 0; then
>>      die "C compiler test failed."
>>  fi
>>  
>> +if test $arch = "x86_32"; then
>> +    # check whether EBP is available on x86
>> +    # As 'i' is stored on the stack, this program will crash
>> +    # if the base pointer is used to access it because the
>> +    # base pointer is cleared in the inline assembly code.
>> +    ebp_available=no
>
> Shouldn't this be replaced with "disable ebp_available" ? (same for ebx)

In fact, it can be removed entirely.  Unset is mostly equivalent to
"no".

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list