[Ffmpeg-devel] Re: suspected non-portable codecs - pnm, png and tta

Ramiro Polla ramiro
Fri Mar 16 05:54:22 CET 2007


Hello,

Loren Merritt escreveu:
> On Fri, 16 Mar 2007, Ramiro Polla wrote:
>
>> Hello,
>>
>> I've been going through all of lavc's files searching for reads and 
>> writes that could be replaced by the bytestream or AV_[RW] functions.
>>
>> Either I'm way too tired, or these lines don't seem to be very 
>> friendly on big-endian machines. Could anyone take a closer look?
>>
>> revision 8421
>> libavcodec/png.c lines 205 and 342
>
> I only see operations on uint8_t*, which is safe.
>

Sorry, I pointed to lines on my patched png.c. The correct lines are 218 
and 355.

>> libavcodec/pnm.c lines 257 and 416
>
> PIX_FMT_RGB32 is defined to be native-endian.
>
>> libavcodec/tta.c line 414
>
> SAMPLE_FMT_S16 is defined to be native-endian.
>
Thank you for the explanation. On png.c it's probably the same thing.

Ramiro Polla





More information about the ffmpeg-devel mailing list