[Ffmpeg-devel] [PATCH] AC-3 encoder volume

Michael Niedermayer michaelni
Sun Mar 18 23:20:51 CET 2007


Hi

On Sun, Mar 18, 2007 at 04:51:19PM -0500, Justin Ruggles wrote:
> Hi everyone,
> 
> This bug has been bothering me for a while.  The AC-3 encoder is
> producing output with too high volume, which even results in clipping in
> many cases.
> 
> The attached patch fixes the problem and updates regressions.  Here is a
> little history.  Revision 5281 changed v-8 to v-9.  Revision 7160
> changed v-9 to v-10.  But after that change I've found the resulting
> file to be noticeably too loud when played.
> 
> To avoid basing the argument on my ears, I've attached a comparison I
> did with a mono clip of a 1kHz tone at 85% of full dynamic range.  The
> screen shot shows 3 different files in Audacity.  The top box is the
> original file, offset by 256 samples to account for the AC-3 delay.  The
> middle box is the results from encoding _without_ the patch, then
> decoding with a52dec.  The bottom box is the results from encoding
> _with_ the patch, then decoding with a52dec.

patch ok, and please cite the whole commit message of the commit this
reverses (with revision number ...) in the new commit message


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I count him braver who overcomes his desires than him who conquers his
enemies for the hardest victory is over self. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070318/5096ae39/attachment.pgp>



More information about the ffmpeg-devel mailing list