[Ffmpeg-devel] Re: [Ffmpeg-cvslog] r8465 - trunk/libavformat/utils.c
Wed Mar 21 13:12:58 CET 2007
On Wed, Mar 21, 2007 at 11:15:52AM -0000, M?ns Rullg?rd wrote:
> Guillaume Poirier said:
> > Hi,
> > diego wrote:
> >> Author: diego
> >> Date: Wed Mar 21 11:48:10 2007
> >> New Revision: 8465
> >> Modified:
> >> trunk/libavformat/utils.c
> >> Log:
> >> av_estimate_timings_from_pts() flushes the packet queue but doesn't
> >> reset the streams' cur_dts values. This can lead to a fatal "error,
> >> non monotone timestamps ..." message later, because the out-of-date
> >> cur_dts values are used to compute some packet's dts.
> >> Fix this by calling av_read_frame_flush() and eliminate code
> >> duplication in the process.
> >> The additional hunk gives more detailed error messages.
> >> patch by Wolfram Gloger, wmglo dent.med.uni-muenchen de
> > Would anyone have an objection to systematically add a reference to
> > the thread where the committed patch was posted?
> > I always do it under "original thread" and give the mail subject and
> > date. Very few people do it currently, which is too bad IMHO.
> > I find it quite handy to immedialty find the discussions there were
> > about the patch, which can sometimes help understanding the patch.
> > Other than the fact that it slows down a bit patch committing, I'd
> > like to hear any objection about making it a policy rule when applying
> > non-trivial patches.
ive no objections to a subject+date rule for applied patches
> When you're anyway adding this information, could you also please include
> the message ID from the mail headers? It makes finding the mail even
this depends entirely on your MUA, also the message-id is generally a few
key presses farther away then the subject and date so i would vote against
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Opposition brings concord. Out of discord comes the fairest harmony.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the ffmpeg-devel