[Ffmpeg-devel] Re: [PATCH] lpcm 20 and 24 bit support in MPEG PS

elupus elupus
Thu Mar 22 22:21:00 CET 2007


> > >>>>>>>>> 
> > >>>>>>>> Any update about that patch ? It fixes a broken
> > >>>>>>>> behaviour and add feature. If it's not ok, I'll fix it
> > >>>>>>>> using another way.
> > >>>>>>>> 
> > >>>>>>> Ping. Ok solution is not beautiful, can we at least add
> > >>>>>>> the bits_per_sample check and error when not 16 bit ?
> > >>>>>>> 
> > >>>>>>> Applying and mentioning "XXX: use AVBistreamFilter" is a
> > >>>>>>> solution too and would add support for those streams.
> > >>>>>>> 
> > >>>>>> Ping....
> > >>>>>> 
> > >>>>> We did had a bug report today because of that issue.
> > >>>> I'm still waiting for Michael to implement or approve some
> > >>>> means of actually using the bitstream filter he says is the
> > >>>> proper way to handle this.

I'm going to bump this as this is still a problem. If there is no intention of 
adding the sample reordering of this patch, how about atleast the part wich 
fixes up bitrate and bits_per_sample. potentially also adding a codecid for 
the 20bit version and "fixing" codecid.

That would atleast allow users to work around it in in players by knowing that 
the mpeg demuxer is in use. As it is now, you have no idea that it's a 
something different than 16bit pcm. Even if you manage to detect it, 
timestamps are totally broken.

/Joakim





More information about the ffmpeg-devel mailing list