[Ffmpeg-devel] Re: [PATCH] lpcm 20 and 24 bit support in MPEG PS

Baptiste Coudurier baptiste.coudurier
Fri Mar 23 02:15:45 CET 2007


Michael Niedermayer wrote:
> Hi
> 
> On Thu, Mar 22, 2007 at 09:21:00PM +0000, elupus wrote:
>>>>>>>>>>>> Any update about that patch ? It fixes a broken
>>>>>>>>>>>> behaviour and add feature. If it's not ok, I'll fix it
>>>>>>>>>>>> using another way.
>>>>>>>>>>>>
>>>>>>>>>>> Ping. Ok solution is not beautiful, can we at least add
>>>>>>>>>>> the bits_per_sample check and error when not 16 bit ?
>>>>>>>>>>>
>>>>>>>>>>> Applying and mentioning "XXX: use AVBistreamFilter" is a
>>>>>>>>>>> solution too and would add support for those streams.
>>>>>>>>>>>
>>>>>>>>>> Ping....
>>>>>>>>>>
>>>>>>>>> We did had a bug report today because of that issue.
>>>>>>>> I'm still waiting for Michael to implement or approve some
>>>>>>>> means of actually using the bitstream filter he says is the
>>>>>>>> proper way to handle this.
>> I'm going to bump this as this is still a problem. If there is no intention of 
>> adding the sample reordering of this patch, how about atleast the part wich 
>> fixes up bitrate and bits_per_sample. potentially also adding a codecid for 
>> the 20bit version and "fixing" codecid.
> 
> iam all in favor of that but iam not mpeg-ps/ts maintainer ...

Ok, it will finally end this thread, may I suggest a CODEC_ID_DVD_LPCM
then ? And decoder which take bits_per_sample into account ?
Using CODEC_ID_PCM_S24BE for it seems a bit weird, this will break
stream copy.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312




More information about the ffmpeg-devel mailing list