[Ffmpeg-devel] [PATCH] Theora in MKV (GSoC '07 Qualification)

Rich Felker dalias
Fri Mar 23 02:59:49 CET 2007


On Fri, Mar 23, 2007 at 01:43:26AM +0100, Michael Niedermayer wrote:
> Hi
> 
> On Thu, Mar 22, 2007 at 08:23:08PM -0400, David Conrad wrote:
> > Hi,
> > 
> > Attached is a patch that allows the Theora decoder to accept the  
> > extradata format used in Matroska. This matches the behaviour of the  
> > Vorbis decoder (in fact, I wound up copying the setup from the Vorbis  
> > decoder; the only difference is the length of the first header.) I  
> 
> as the code is identical to vorbis, it should not be duplicated but
> rather shared. putting the code into a common file xiph.c xiph.h maybe?
> would be better

Agree, that would be very nice! Also the Theora decoder should ensure
that it does not accept headers in data packets, only in extradata,
and any demuxers (ogg?) that output the headers in data packets should
be fixed to use extradata.

Rich




More information about the ffmpeg-devel mailing list