[Ffmpeg-devel] [PATCH] Theora in MKV (GSoC '07 Qualification)

Michael Niedermayer michaelni
Fri Mar 23 10:18:10 CET 2007


On Thu, Mar 22, 2007 at 10:04:00PM -0400, David Conrad wrote:
> On Mar 22, 2007, at 9:56 PM, David Conrad wrote:
> >On Mar 22, 2007, at 8:43 PM, Michael Niedermayer wrote:
> >
> >>Hi
> >>
> >>On Thu, Mar 22, 2007 at 08:23:08PM -0400, David Conrad wrote:
> >>>Hi,
> >>>
> >>>Attached is a patch that allows the Theora decoder to accept the
> >>>extradata format used in Matroska. This matches the behaviour of the
> >>>Vorbis decoder (in fact, I wound up copying the setup from the  
> >>>Vorbis
> >>>decoder; the only difference is the length of the first header.) I
> >>
> >>as the code is identical to vorbis, it should not be duplicated but
> >>rather shared. putting the code into a common file xiph.c xiph.h  
> >>maybe?
> >>would be better
> >
> >Something like the attached?
> Trailing whitespace removed (forgot to check before sending...)

patch looks ok


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070323/c6537a89/attachment.pgp>

More information about the ffmpeg-devel mailing list