[Ffmpeg-devel] Shorten file playback broken in SVN trunk

Aurelien Jacobs aurel
Sun Mar 25 18:34:05 CEST 2007


On Sat, 24 Mar 2007 17:04:23 +0100
Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> Hello,
> On Sat, Mar 24, 2007 at 04:42:15PM +0100, Diego Biurrun wrote:
> > On Sat, Mar 24, 2007 at 04:04:53AM +0100, Diego 'Flameeyes' Petten?? wrote:
> > > Somehow the playback of Shorten (SHN) files seems to be broken in
> > > current SVN trunk, and was already since at least the 20070129 snapshot
> > > Luca (lu_zero) added to portage, while reportedly worked on 20061016
> > > snapshot. I don't have the svn revision numbers at hand, but Luca might
> > > have them.
> > > 
> > > I can reproduce this with the luckynight.shn sample, both using
> > > ffplay (that does not play anything) and xine (that plays something but
> > > totally out of time).
> > 
> > I just bisected this, the commit that breaks Shorten playback is:
> > 
> > ------------------------------------------------------------------------
> > r7518 | michael | 2007-01-15 00:50:06 +0100 (Mon, 15 Jan 2007) | 3 lines
> > 
> > avcodec_decode_audio2()
> > difference to avcodec_decode_audio() is that the user can pass the
> > allocated size of the output buffer to the decoder and the decoder can
> > check if theres enough space
> > ------------------------------------------------------------------------
> 
> This most likely means that the shorten decoder returns with a value >=
> 0 but without setting data_size, which is incorrect.

Indeed this seems to be the problem.
Attached patch fixes playback of shorten files. I will apply soon.

Aurel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shorten-fix.diff
Type: text/x-diff
Size: 433 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070325/7e88d4f8/attachment.diff>



More information about the ffmpeg-devel mailing list