[Ffmpeg-devel] Re: Bethsoft VID demuxer and decoder

Benoit Fouet benoit.fouet
Tue Mar 27 09:38:16 CEST 2007


Hi,

Nicholas T wrote:
>> trailing whitespace is forbidden in svn
> do you mean a newline with only spaces afterwards?
>
a line terminated by one or more white space(s)

>> constants be they #defined or from a enum should be all UPPERCASE
> done, but they're a little bit less legible
> VIDEOOFFSETDIFFERENCEFRAME_BLOCK vs VideoOffsetDifferenceFrame_Block
>
and what about VIDEO_OFFSET_DIFFERENCE_FRAME_BLOCK ?
[snip]

>> the {} are superfluous also indention is wrong
> I usually like {} b/c if you delete the statement afterwards you are
> messed
> up. According to kwrite, which has pretty good format specifications, the
> indentation isn't wrong, but I changed it anyway.
>
Kwrite does what you ask it to... as every (configurable) editor...

Ben




More information about the ffmpeg-devel mailing list