[Ffmpeg-devel] BlackFin lowlevel pixel operations PATCH

Marc Hoffman mmh
Tue Mar 27 13:11:33 CEST 2007


Diego Biurrun writes:
 > On Mon, Mar 26, 2007 at 10:00:39PM -0400, Marc Hoffman wrote:
 > Content-Description: message body text
 > > 
 > > This is the a set of video optimization for the Blackfin processor it
 > > includes most of the low level pixel operations.
 > > 
 > > --- libavcodec/Makefile	(revision 8517)
 > > +++ libavcodec/Makefile	(working copy)
 > > @@ -396,8 +396,13 @@
 > >  OBJS-$(CONFIG_WMV3_DECODER)            += ppc/vc1dsp_altivec.o
 > >  endif
 > >  
 > > -OBJS-$(TARGET_ARCH_BFIN)               += bfin/dsputil_bfin.o \
 > > +OBJS-$(TARGET_ARCH_BFIN)               += bfin/dsputil_bfin.o 
 > 
 > Cosmetics; also this was the way it was on purpose.
 > 
 > > +ASM_OBJS-$(TARGET_ARCH_BFIN)           += bfin/pixels_bfin.o \
 > > +		                          bfin/idct_bfin.o\
 > > +					  bfin/fdct_bfin.o 
 > 
 > Put a backslash after the last line as well so we can add another entry
 > without modifying the line.
 > 
 > > ===================================================================
 > > --- libavcodec/bfin/fdct_bfin.S	(revision 0)
 > > +++ libavcodec/bfin/fdct_bfin.S	(revision 0)
 > > @@ -0,0 +1,358 @@
 > > +/*				-*- text -*-
 > > + * This file is part of FFmpeg.
 > > + *
 > > + * This library is free software; you can redistribute it and/or
 > > + * modify it under the terms of the GNU Lesser General Public
 > > + * License as published by the Free Software Foundation; either
 > > + * version 2 of the License, or (at your option) any later version.
 > > + *
 > > + * This library is distributed in the hope that it will be useful,
 > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
 > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 > > + * Lesser General Public License for more details.
 > > + *
 > > + * You should have received a copy of the GNU Lesser General Public
 > > + * License along with this library; if not, write to the Free Software
 > > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 > > + */
 > 
 > The license header is wrong, just copy and paste a correct one from
 > another file.  Dunno where you got this one from.
 > 
 > > --- libavcodec/bfin/idct_bfin.S	(revision 0)
 > > +++ libavcodec/bfin/idct_bfin.S	(revision 0)
 > > @@ -0,0 +1,238 @@
 > > +/*				-*- text -*-
 > > + * This file is part of FFmpeg.
 > > + *
 > > + * This library is free software; you can redistribute it and/or
 > > + * modify it under the terms of the GNU Lesser General Public
 > > + * License as published by the Free Software Foundation; either
 > > + * version 2 of the License, or (at your option) any later version.
 > > + *
 > > + * This library is distributed in the hope that it will be useful,
 > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
 > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 > > + * Lesser General Public License for more details.
 > > + *
 > > + * You should have received a copy of the GNU Lesser General Public
 > > + * License along with this library; if not, write to the Free Software
 > > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 > > + */
 > 
 > same here
 > 
 > > --- libavcodec/bfin/dsputil_bfin.c	(revision 8517)
 > > +++ libavcodec/bfin/dsputil_bfin.c	(working copy)
 > > @@ -1,55 +1,319 @@
 > >  /*
 > >   * This file is part of FFmpeg.
 > >   *
 > > - * FFmpeg is free software; you can redistribute it and/or
 > > + * This library is free software; you can redistribute it and/or
 > >   * modify it under the terms of the GNU Lesser General Public
 > >   * License as published by the Free Software Foundation; either
 > > - * version 2.1 of the License, or (at your option) any later version.
 > > + * version 2 of the License, or (at your option) any later version.
 > >   *
 > > - * FFmpeg is distributed in the hope that it will be useful,
 > > + * This library is distributed in the hope that it will be useful,
 > >   * but WITHOUT ANY WARRANTY; without even the implied warranty of
 > >   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 > >   * Lesser General Public License for more details.
 > >   *
 > >   * You should have received a copy of the GNU Lesser General Public
 > > - * License along with FFmpeg; if not, write to the Free Software
 > > + * License along with this library; if not, write to the Free Software
 > >   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 > >   */
 > 
 > And now you're breaking a header that was correct before ..
 > 
 > > --- libavcodec/bfin/pixels_bfin.S	(revision 0)
 > > +++ libavcodec/bfin/pixels_bfin.S	(revision 0)
 > > @@ -0,0 +1,724 @@
 > > +/*				-*- text -*-
 > > + * This file is part of FFmpeg.
 > > + *
 > > + * This library is free software; you can redistribute it and/or
 > > + * modify it under the terms of the GNU Lesser General Public
 > > + * License as published by the Free Software Foundation; either
 > > + * version 2 of the License, or (at your option) any later version.
 > > + *
 > > + * This library is distributed in the hope that it will be useful,
 > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
 > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 > > + * Lesser General Public License for more details.
 > > + *
 > > + * You should have received a copy of the GNU Lesser General Public
 > > + * License along with this library; if not, write to the Free Software
 > > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 > > + */
 > 
 > see above
 > 
 > > --- libavcodec/bfin/config_bfin.h	(revision 0)
 > > +++ libavcodec/bfin/config_bfin.h	(revision 0)
 > > @@ -0,0 +1,13 @@
 > > +#ifndef DEFUN
 > > +#ifndef mL1
 > > +#define mL1 .l1.text
 > > +#endif
 > > +#define mL3 .text
 > > +
 > > +#define DEFUN(fname,where,interface) \
 > > +	.section where; \
 > > +	.global _ ## fname ## _bfin; \
 > > +	.align 8; \
 > > +	_ ## fname ## _bfin
 > > +#endif
 > 
 > This file lacks a license header.
 > 
 > Diego
 > _______________________________________________
 > ffmpeg-devel mailing list
 > ffmpeg-devel at mplayerhq.hu
 > http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

Is this the right one version 2 changes to 2.1 and a couple of other
words.  Good catch, just double check this one.

/*				-*- text -*-
 * Copyright (C) 2007 Marc Hoffman <marc.hoffman at analog.com>
 *
 * Blackfin Pixel Operations
 *  
 * This file is part of FFmpeg.
 *
 * FFmpeg is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * FFmpeg is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with FFmpeg; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 */




More information about the ffmpeg-devel mailing list