[Ffmpeg-devel] [PATCH] support v4l2 video source and normid input

Luca Abeni lucabe72
Tue Mar 27 16:31:32 CEST 2007


Hi Limin,

Limin Wang wrote:
[...]
>>> Please apply this patch if it's OK, the last patch has one debug typo 
>>> error.
>> sorry for the late reply, I had some email problems.
>> Anyway, I'll look at your patch asap, and I'll let you know. As a first 
>> impression, I like this patch much better than the first one ;)
> 
> That's OK, I haven't updated the comment about these options, it'll be another separate
> patch if the patch is applied.
I looked at your patch, and it seems to be ok. I only had to change

+ av_log(s1, AV_LOG_DEBUG, "The V4L2 driver set standard: %s, id: %d\n",
+        ap->standard, standard.id);
into
+ av_log(s1, AV_LOG_DEBUG, "The V4L2 driver set standard: %s, id:%Lu\n",
+        ap->standard, standard.id);
to avoid a warning.

Unfortunately, I have no access to video4linux hardware anymore, so I 
cannot test the patch. But it looks safe, so if noone complains I'll 
apply it in one day (so, if anyone sees problems, please speak up).


			Thanks,
				Luca




More information about the ffmpeg-devel mailing list