[Ffmpeg-devel] Re: [PATCH] Set bit_rate for asf format

Zuxy Meng zuxy.meng
Wed Mar 28 17:21:22 CEST 2007


Hi,

2007/3/28, Baptiste Coudurier <baptiste.coudurier at smartjog.com>:
> Ramiro Ribeiro Polla wrote:
> > Baptiste Coudurier wrote:
> >> Hi
> >>
> >> Zuxy Meng wrote:
> >>
> >>> Hi
> >>>
> >>> 2007/3/23, Michael Niedermayer <michaelni at gmx.at>:
> >>>
> >>>> Hi
> >>>>
> >>>> On Tue, Mar 20, 2007 at 12:40:19PM +0800, Zuxy Meng wrote:
> >>>>
> >>>>> Hi,
> >>>>>
> >>>>> As $subj. I tested with several asf files and the bitrate is the same
> >>>>> as reported by WMP.
> >>>>>
> >>>> patch ok, asf is a ugly beast ...
> >>>>
> >>>>
> >>> Anyone willing to apply it?
> >>>
> >>
> >> Yes, applied.
> >>
> >>
> >
> > It breaks regression tests with a bunch of "overflow in spectral RLE,
> > ignoring".
>
> Humm, right, libavtest pass, but not fulltest:
>
> --- ./data/ffmpeg.regression    2007-03-28 16:41:22.000000000 +0200
> +++ /usr/local/src/ffmpeg/svn/tests/ffmpeg.regression.ref
> 2007-03-26 14:25:07.000000000 +0200
> @@ -190,9 +190,9 @@
>  stddev: 33.31 PSNR:65.87 bytes:1040384
>  0c406c4e4586ca27064e28637b662631 *./data/a-wmav1.asf
>  106004 ./data/a-wmav1.asf
> -stddev:9580.26 PSNR:16.69 bytes:1056768
> -stddev:9613.11 PSNR:16.66 bytes:1048576
> +stddev:12251.50 PSNR:14.56 bytes:1056768
> +stddev:2106.00 PSNR:29.85 bytes:1048576
>  82442aaa5fdbd327769e4c4ad369147e *./data/a-wmav2.asf
>  106044 ./data/a-wmav2.asf
> -stddev:16624.59 PSNR:11.90 bytes:1056768
> -stddev:16691.39 PSNR:11.87 bytes:1048576
> +stddev:12255.92 PSNR:14.55 bytes:1056768
> +stddev:2099.31 PSNR:29.88 bytes:1048576
>
> I revert the patch until this is stated, and will be more careful in the
> future.
>
> Thanks for noticing.

Problem might be that the bit_rate should only be set for video streams, so
    if (codec->codec_type == CODEC_TYPE_VIDEO)
        codec->bit_rate = bitrate[i];
should be used.

I'll try to get the fulltest result.
-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6




More information about the ffmpeg-devel mailing list