[Ffmpeg-devel] BlackFin lowlevel pixel operations PATCH

[Diego Biurrun]

On Wed, Mar 28, 2007 at 05:49:14PM -0400, Marc Hoffman wrote:
Content-Description: message body text
> 
> how does this look now? Thanks Marc
 
The patch is full of trailing whitespace.  Remove it.

> --- Makefile	(revision 8517)
> +++ Makefile	(working copy)
> @@ -398,6 +398,11 @@
>  
> +ASM_OBJS-$(TARGET_ARCH_BFIN)           += bfin/pixels_bfin.o \
> +		                          bfin/idct_bfin.o   \
> +					  bfin/fdct_bfin.o   \
> +		                          bfin/xidct.o	     \

Indentation is messed up because you use tabs here, use spaces instead.

> --- bfin/fdct_bfin.S	(revision 0)
> +++ bfin/fdct_bfin.S	(revision 0)
> @@ -0,0 +1,383 @@
> +/*                              -*- text -*-
> --- bfin/idct_bfin.S	(revision 0)
> +++ bfin/idct_bfin.S	(revision 0)
> @@ -0,0 +1,422 @@
> +/*                              -*- text -*-
> --- bfin/config_bfin.h	(revision 0)
> +++ bfin/config_bfin.h	(revision 0)
> @@ -0,0 +1,34 @@
> +/*                              -*- text -*-

Why do you force these files to be treated as text files by emacs?  IMO
this should not be in your patch, especially not for the header file.

Diego