[Ffmpeg-devel] [PATCH] add all and none options for partitions config

Limin Wang lance.lmwang
Thu Mar 29 05:35:34 CEST 2007


Hi Michael,

[snip]
> 
> your patch added AVOptions with unit="partitions" so its specific to 
> partitions, which is bad
> 
> either add it with unit=NULL and if needed fix the AVOption code or
> 
> or better fix av_set_string() so it parses all&none like max/min/default

I have fixed it in av_set_string, please review it.


Thanks,
Limin
-------------- next part --------------
Index: libavcodec/opt.c
===================================================================
--- libavcodec/opt.c	(revision 8540)
+++ libavcodec/opt.c	(working copy)
@@ -139,6 +139,8 @@
                 else if(!strcmp(buf, "default")) d= o->default_val;
                 else if(!strcmp(buf, "max"    )) d= o->max;
                 else if(!strcmp(buf, "min"    )) d= o->min;
+                else if(!strcmp(buf, "none"   )) d= 0;
+                else if(!strcmp(buf, "all"    )) d= ~0;
                 else {
                     if (!error)
                         av_log(NULL, AV_LOG_ERROR, "Unable to parse option value \"%s\": %s\n", val, error);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 481 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070329/50bae9ee/attachment.pgp>



More information about the ffmpeg-devel mailing list