[Ffmpeg-devel] Fix missing declaration for Altivec

Måns Rullgård mans
Thu Mar 29 16:38:13 CEST 2007


Stanislav Brabec said:
> Hallo.
>
> Attached patch fixes missing declaration if HAVE_ALTIVEC is true.
>
> Author: Andreas Schwab.
>
> --- libswscale/yuv2rgb.c
> +++ libswscale/yuv2rgb.c
> @@ -606,6 +606,7 @@
>  #ifdef HAVE_ALTIVEC
>      if (c->flags & SWS_CPU_CAPS_ALTIVEC)
>      {
> +	extern SwsFunc yuv2rgb_init_altivec(SwsContext *);
>  	SwsFunc t = yuv2rgb_init_altivec(c);
>  	if(t) return t;
>      }

Firmly rejected.  Prototypes for extern functions belong in a header file
included by the file with the function definition and every file that uses
the function.  Anything else is asking for trouble.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list